Repository navigation
Conversation
buildAxis takes the ceiling of the label floor over the unit width. The call site divides the unit width by scaling, so a width on an exact multiple of the floor can land a hair under it (29.4 / 1.05 = 27.999999999999996) and thin one step too far. Subtract a small epsilon before the ceiling.
The default estimatedRowHeight scales with the theme's scaling, but the demo cards had a fixed 64px height. At a larger scaling the card content grew while the card did not. Scale the card height with --rs-scaling and document this on the timeline page.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
No actionable comments were generated in the recent review. Walkthrough
Merge Risk:
|
commit: |
Summary
buildAxissubtracts a small epsilon before taking the ceiling of label floor / unit width. Dividing the unit width by scaling can leave a value a hair under an exact multiple (29.4 / 1.05 = 27.999999999999996), which thinned the axis one step too far and dropped tick labels.Adds tests for widths on exact spacing boundaries.
The timeline demo and stress-page cards use
calc(64px * var(--rs-scaling, 1))for their height, so they stay inside the default lane height, which scales with the theme.The timeline docs page says to scale an explicit card height when the scaling can change.
I have followed the pull request section of the contributing guide.